On Thu, 12 Mar 2026 14:51:59 GMT, Matthias Baesken <[email protected]> wrote:

> We use a struct DL_info on AIX (similar to the struct on Linux) to support 
> dladdr, but currently it is available 3 times (even in slightly different 
> versions).
> This should be unified and put into a single header.

make/common/modules/LauncherCommon.gmk line 40:

> 38: LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/share/native/launcher \
> 39:     -I$(TOPDIR)/src/java.base/share/native/libjli \
> 40:     -I$(TOPDIR)/src/java.base/$(OPENJDK_TARGET_OS)/native/include \

I think this should be made conditional, on AIX only

make/hotspot/lib/JvmFlags.gmk line 50:

> 48:     -I$(TOPDIR)/src/hotspot/share/include \
> 49:     -I$(TOPDIR)/src/hotspot/os/$(HOTSPOT_TARGET_OS_TYPE)/include \
> 50:     -I$(TOPDIR)/src/java.base/$(HOTSPOT_TARGET_OS)/native/include \

same here, make this conditional, on AIX only

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2929522111
PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2929523018

Reply via email to