On Tue, 17 Mar 2026 01:24:28 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Many classes have no space between operator and operand which needs to be
>> rectified
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comment
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java line
1077:
> 1075: }
> 1076:
> 1077: if (scroller != null &&
> scroller.getComponentOrientation()!=o) {
This looks weird and half-baked… You added spaces around `!=` on the left of
the `&&` operator but you didn't add spaces on the right side.
Now both `if` conditions are even *less consistent* than they were before this
fix.
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java
line 911:
> 909:
> 910: boolean isInPopup(Component src) {
> 911: for (Component c=src; c != null; c=c.getParent()) {
Here we go again, only the middle expression now has spaces around an operator,
but two others do not.
It should've looked like this:
for (Component c = src; c != null; c = c.getParent()) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30257#discussion_r2953959286
PR Review Comment: https://git.openjdk.org/jdk/pull/30257#discussion_r2953971972
