On Fri, 20 Mar 2026 03:25:26 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Few formatting issues were missed in >> [JDK-8380125](https://bugs.openjdk.org/browse/JDK-8380125) which needs to be >> fixed > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - Some more formatting fix > - Some more formatting fix Perhaps, we should rather stop *wasting time* by updating formatting and reviewing it—I see no benefit to it, especially when there are numerous inconsistencies in `plaf/{basic,nimbus,synth}`… These small fixes don't make the files fully consistent… in a way these fixes only bring more inconsistencies. I suggest limiting this updates to fix inconsistencies introduced by #30257 inside the touched methods and leave everything else intact. You should also bump up the copyright year for all the files you updated in #30257 for [JDK-8380125](https://bugs.openjdk.org/browse/JDK-8380125). Also realign the comment: https://github.com/openjdk/jdk/blob/18fdbd2404b3b6b23ba8457e4c42674ffc3fffa4/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java#L4092-L4095 `// Add placeholder ` was aligned to other comments before #30310. src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuBarUI.java line 243: > 241: for(i = 0,c = menuBar.getMenuCount() ; i < c ; i++) { > 242: JMenu menu = menuBar.getMenu(i); > 243: if(menu != null && menu.isSelected()) { Suggestion: if (menu != null && menu.isSelected()) { ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30310#pullrequestreview-4002136056 PR Comment: https://git.openjdk.org/jdk/pull/30310#issuecomment-4121329655 PR Review Comment: https://git.openjdk.org/jdk/pull/30310#discussion_r2984174570
