On Mon, 30 Mar 2026 19:10:26 GMT, Phil Race <[email protected]> wrote:

>> This is to address removing AppContext from various places in the AWT 
>> implementation.
>> 
>> This most substantial is in various XAWT / Toolkit related classes to remove 
>> AppContext lookup in event dispatching and related code
>> 
>> - An unused field of a native XAWT structure references the appContext field 
>> of a Component and so it is deleted
>> 
>> - The same exists in windows, and although nothing to do with XAWT it is 
>> cleaned up here
>> 
>> - one obsolete comment (no code change) is removed from a PerformanceLogger 
>> class
>> 
>> No tests fail.
>
> Phil Race has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8380578

Marked as reviewed by azvegint (Reviewer).

src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java line 632:

> 630:                 // for compatibility reasons. Probably some time later 
> we'll remove
> 631:                 // the check for AppContext.isDisposed() and will 
> unconditionally
> 632:                 // break the loop here.

It looks like this if block is no longer skipping anything and can be removed

-------------

PR Review: https://git.openjdk.org/jdk/pull/30362#pullrequestreview-4038784818
PR Review Comment: https://git.openjdk.org/jdk/pull/30362#discussion_r3017166938

Reply via email to