On Mon, 30 Mar 2026 09:08:40 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>>> You mention that the fix is for linux as well but it seems all the files >>> fixed are for macos, except one where IllegalArgumentException is touched. >>> I hope you have not missed adding PSPrinterJob fix to this.. >> >> Changes in the CustomMediaSize.java and CustomMediaSizeName.java affect >> macOS and Linux. >> The PSPrinterJob.java does not require changes because the desired >> orientation of the print-stream pages is specified within the postscript >> document data and already implemented. > >> > You mention that the fix is for linux as well but it seems all the files >> > fixed are for macos, except one where IllegalArgumentException is touched. >> > I hope you have not missed adding PSPrinterJob fix to this.. >> >> Changes in the CustomMediaSize.java and CustomMediaSizeName.java affect >> macOS and Linux. The PSPrinterJob.java does not require changes because the >> desired orientation of the print-stream pages is specified within the >> postscript document data and already implemented. > > I see the regression test `MediaPrintableAreaTest `does not fail in > ubuntu24.04 and I get the following output when logged > and as you told it's already implemented so I believe there's no need to > change anything in Linux but above you once told > >> "It's not a regression. JDK-8295737 fixed a related issue on macOS but did >> not fix the bug on Linux. " > > .so there's still some confusion as to what it fixed in Linux..If no file in > unix is changed, how is it being fixed and considering the regression test > does not fail there. > > > mediaWidth 215.89999389648438 printavleWidth 209.5500030517578 > mediaWidth 210.0 printavleWidth 203.55300903320312 > mediaWidth 279.3999938964844 printavleWidth 273.0500183105469 > mediaWidth 297.0 printavleWidth 290.6889953613281 > mediaWidth 148.0 printavleWidth 142.16900634765625 > mediaWidth 182.0 printavleWidth 175.68299865722656 > mediaWidth 104.7750015258789 printavleWidth 98.42499542236328 > mediaWidth 162.0 printavleWidth 155.57501220703125 > mediaWidth 110.0 printavleWidth 103.71699523925781 > mediaWidth 176.0 printavleWidth 169.68600463867188 > mediaWidth 98.2979965209961 printavleWidth 92.07499694824219 > mediaWidth 184.14999389648438 printavleWidth 177.8000030517578 > mediaWidth 215.89999389648438 printavleWidth 209.5500030517578 > mediaWidth 215.89999389648438 printavleWidth 209.5500030517578 > mediaWidth 210.0 printavleWidth 203.55300903320312 > mediaWidth 279.3999938964844 printavleWidth 273.0500183105469 > mediaWidth 297.0 printavleWidth 290.6889953613281 > mediaWidth 148.0 printavleWidth 142.16900634765625 > mediaWidth 182.0 printavleWidth 175.68299865722656 > mediaWidth 104.7750015258789 printavleWidth 98.42499542236328 > mediaWidth 162.0 printavleWidth 155.57501220703125 > mediaWidth 110.0 printavleWidth 103.71699523925781 > mediaWidth 176.0 printavleWidth 169.68600463867188 > mediaWidth 98.2979965209961 printavleWidth 92.07499694824219 > mediaWidth 184.14999389648438 printavleWidth 177.8000030517578 @prsadhuk Sorry for the delay. It looks like your printer does not support landscape-oriented paper, so the test does not fail. I added additional output message that warns about the missing paper orientation. I use virtual printer-driver-cups-pdf or Canon thermal printer that support landscape-oriented paper to run MediaPrintableAreaTest on Linux. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29560#issuecomment-4198686473
