On Tue, 21 Apr 2026 03:48:23 GMT, Jeremy Wood <[email protected]> wrote:

>> If `swing.volatileImageBufferEnabled` is turned off: MTLGraphicsConfig and 
>> CGLGraphicsConfig should use a translucent image for double buffering.
>> 
>> This test is marked as mac-only, but it should be harmless to turn that flag 
>> off if anyone wants to test other platforms. In previous threads we 
>> established that this is a Mac-only issue: 
>> https://github.com/openjdk/jdk/pull/23430#discussion_r1940881969
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jeremy Wood has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8382201: reinstating correct properties
>   
>   I must have gotten my tickets mixed up when I removed these properties. We 
> DO want to toggle opengl (so we test both MTL and CGL), and we want volatile 
> images permanently off for this test.

test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 27:

> 25:  * @test
> 26:  * @bug     8382201
> 27:  * @summary This tests window translucency when

The test needs
@key headful

test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 30:

> 28:  *          `swing.volatileImageBufferEnabled=false`
> 29:  * @requires os.family == "mac"
> 30:  * @library /java/awt/regtesthelpers

I don't see any use of regtesthelpers here

test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 95:

> 93:         try {
> 94:             SwingUtilities.invokeAndWait(() -> {
> 95:                 JDialog translucentDialog = createDialog();

This dialog is never disposed, so you are relying on jtreg shutting the test 
down to cause the test to terminate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126749810
PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126755493
PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126753657

Reply via email to