On Mon, 27 Apr 2026 20:31:12 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8377568
>
> test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 543:
>
>> 541: static boolean failed = false;
>> 542:
>> 543: static final int[] nullOffsets = null;
>
> nullOffsets is unsed?
Unused
BTW IIn my pass earlier, I missed the comments on this file because GitHub
didn't open it because it was too large.
> test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 659:
>
>> 657: final int[] zeroIntArray = { };
>> 658: final int[] oneIntArray = { 0 } ;
>> 659: final int[] tenIntArray = new int[100];
>
> is it expected "tenXX" vs "100"?
should be 10
> test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 662:
>
>> 660: final int[] oneKIntArray = new int[1000];
>> 661: final int[][] nullIntArrays = null;
>> 662: final int[][] nullIntSubArrays = { nullIntArray } ;
>
> Is "nullIntSubArrays"/nullxxx.. truly unused or some checks are missed in the
> test?
There are few of these which we don't use. I've removed them
> test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 682:
>
>> 680: testIntConstructor(oneIntArray, 2,
>> IllegalArgumentException.class);
>> 681:
>> 682: // DataBufferInt(byte[] dataArray, int size, int offset)
>
> Copy paste error? should be int[]?
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3157847616
PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3157848311
PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3157851427
PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3157856596
