On Thu, 30 Apr 2026 21:37:20 GMT, Phil Race <[email protected]> wrote:
>> This fix updates DataBuffer subclasses to actually adhere to their stated >> specifications by rejecting certain invalid parameters for constructors and >> getters and setters. >> A new egression test for each of the constructor and getter/setter cases is >> supplied. >> >> No existing regression tests fail with this change, and standard demos work. >> >> Problems caused by these changes are most likely to occur if the client has >> a bug such that >> - a client uses the constructors that accept an array and then supplies a >> "size" that is greater than the array. >> - a client uses the constructors that accept an array and then supplies a >> "size" that is less than the array and then uses getter/setters that are >> within the array but outside the range specified by size. >> >> Since very few clients (and just one case in the JDK that I found) even use >> these array constructors the changes are unlikely to make a difference to >> clients. >> >> The CSR is ready for review https://bugs.openjdk.org/browse/JDK-8378116 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8377568 Changes requested by aivanov (Reviewer). test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 644: > 642: // DataBufferShort(short[][] dataArray, int size) > 643: testShortConstructor(nullShortArrays, 0, signed, > NullPointerException.class); > 644: testShortConstructor(nullShortSubArrays,1, signed, > NullPointerException.class); Suggestion: testShortConstructor(nullShortSubArrays, 1, signed, NullPointerException.class); Missing a space after the comma. test/jdk/java/awt/image/DataBuffer/DataBufferConstructorTest.java line 652: > 650: testShortConstructor(oneShortSubArrays, 1, nullOffsetArray, > signed, NullPointerException.class); > 651: testShortConstructor(nullShortArrays, 0, zeroOffsetArray, > signed, NullPointerException.class); > 652: testShortConstructor(zeroShortSubArrays, 0, zeroOffsetArray, > signed, IllegalArgumentException.class); Missing a test for `nullShortSubArrays`. ------------- PR Review: https://git.openjdk.org/jdk/pull/29766#pullrequestreview-4212255864 PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3174194180 PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3174202960
