On Wed, 20 May 2026 22:22:56 GMT, Phil Race <[email protected]> wrote:

>> src/java.desktop/share/classes/java/awt/image/BandedSampleModel.java line 
>> 176:
>> 
>>> 174:      * @throws ArrayIndexOutOfBoundsException if any of the bank 
>>> indices is out of bounds
>>> 175:      */
>>> 176:     public SampleModel createSubsetSampleModel(int[] bands) {
>> 
>> Do we need to update the spec for the parent SampleModel class?
>
> In the "description" of this PR I wrote
> "The super-class SampleModel. createSubsetSampleModel is NOT updated because 
> in fact one subclass behaves differently because it supports only one band."

but description of that one subclass spec will overwrite the parent spec, no? 
MultiPixelPackedSampleModel will be updated anyway that the bands parameter is 
ignored and all possible validations of it will be skipped as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30902#discussion_r3277884209

Reply via email to