On Fri, 29 May 2026 03:33:14 GMT, Sergey Bylokhov <[email protected]> wrote:
>> This will require a larger refactoring and additional testing, so it can be >> done as a separate fix. >> >> Given that there is less than a week before RDP1, I prefer a tested solution. > > not sure that this version with timers/retries is actually safer. Considering > that JDK-8185862 was backout from JDK 17 and 21 it might be better to do the > same here. > > BTW, there were two different patches for JDK-8185862: > 1. https://github.com/openjdk/jdk/pull/17197/changes - tries to ignore the > assertion and use a default bitmap > 2. https://github.com/openjdk/jdk/pull/17614/changes - excludes virtual > displays and filters out all cases where CreateDC fails > > Based on how many regressions this caused, should we reconsider that fix and > allow virtual displays again? What was the actual point to block it? This fix is supposed to fix the crashes. I think the issues above relate to "default headless", which I think we should consider a distinct issue and I think the current (new) behaviour on that front is what we should have done all along. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31238#discussion_r3326032814
