> [JDK-8348760](https://bugs.openjdk.org/browse/JDK-8348760) fixed an issue in > Windows L&F JMenuItem layout whereby radio bullet/checkmark was rendered in > different columnspace than menuitem imageicon so radiobullet/checkmark is > rendered in first column and imageicon is rendered in 2nd column but this > rendering of imageicon in 2nd columnspace was done invariably for all > JMenuItem irrespective of if it is JRadioButtonMenuItem or JCheckBoxMenuItem > or JMenuItem, which is wrong. > > Normal JMenuItem (which are not JRadioButtonMenuItem or JCheckBoxMenuItem) > imageicon rendering should be done in first columnspace as was done before > JDK-8348760 fix because there is no radiobullet/checkmark to render for those > menuitems so no need to reserve columnspace for those bullet/checkmark icon > > Before fix > > <img width="205" height="127" alt="image" > src="https://github.com/user-attachments/assets/13a1e352-5e8d-4251-b7a7-032935eab74e"; > /> > > > After fix > > <img width="195" height="131" alt="image" > src="https://github.com/user-attachments/assets/84ec3ee6-2823-4bf7-840d-b53f2e9d44c3"; > /> > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8370945 - Test applicable for all L&F - Test update with 2nd menu - Fix - Fix - Static usage removed - Fix update as per rules - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8370945 - Fix - Text alignment - ... and 2 more: https://git.openjdk.org/jdk/compare/1e1c9696...7ed99058 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29730/files - new: https://git.openjdk.org/jdk/pull/29730/files/3172488d..7ed99058 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29730&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29730&range=07-08 Stats: 174188 lines in 3408 files changed: 56969 ins; 102182 del; 15037 mod Patch: https://git.openjdk.org/jdk/pull/29730.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29730/head:pull/29730 PR: https://git.openjdk.org/jdk/pull/29730
