On Tue, 30 Jun 2026 13:26:46 GMT, Matthias Baesken <[email protected]> wrote:
> We have at least 2 isXP() functions in the coding checking for very old > Windows versions. These can be removed. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Changes requested by dgredler (Committer). src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 444: > 442: error = modify(true); > 443: if (error == 0) { > 444: regEnable(); The check is "not XP", so this function call should be removed, no? Assuming this is the case, please also check whether we call `regEnable` anywhere else, it looks like we might be able to delete the whole function. (Caveat: I'm not very familiar with this jdk.accessibility module.) src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 451: > 449: error = modify(false); > 450: if (error == 0) { > 451: regDisable(); Same as above, and we may be able to remove `regDisable` entirely. ------------- PR Review: https://git.openjdk.org/jdk/pull/31725#pullrequestreview-4610393785 PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3507075501 PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3507085357
