On Thu, 2 Jul 2026 13:13:04 GMT, Alexey Ivanov <[email protected]> wrote:
> I've run the changeset through our CI, all the client tests are green.
Sounds great, thanks for testing it in your CI !
> src/java.desktop/windows/native/libawt/windows/awt_DesktopProperties.cpp line
> 442:
>
>> 440: if (!settingsChanged && fontSmoothingType ==
>> FONTSMOOTHING_STANDARD) {
>> 441: /* No need to check any LCD specific settings */
>> 442: return;
>
> It looks to me the condition should've been
>
>
> Suggestion:
>
> if (!settingsChanged || fontSmoothingType == FONTSMOOTHING_STANDARD) {
> /* No need to check any LCD specific settings */
> return;
>
>
> That is we get into this early exist branch if nothing's changed or if new
> font smoothing is `FONTSMOOTHING_STANDARD` (non-LCD).
Let's do this in a separate issue/PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/31676#issuecomment-4866412872
PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3513504383
