On Fri, 3 Jul 2026 07:06:51 GMT, Matthias Baesken <[email protected]> wrote:
> The IS_WINVISTA macro is obsolete these days, because we run on higher > Windows versions as a minimum requirement. > Same is true for the isVistaOS() method. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Just as a clarification: IS_VISTA was true on Vista and later, or just on Vista? Looks okay to me, but I think @prrace will want to have a look at awt changes too. src/java.desktop/windows/classes/sun/awt/windows/WComponentPeer.java line 1085: > 1083: public boolean isAccelCapable() { > 1084: if (!isAccelCapable || > 1085: !isContainingTopLevelAccelCapable((Component)target)) { I'd remove the whitespace-only change, makes for easier reviewing. src/java.desktop/windows/classes/sun/awt/windows/WWindowPeer.java line 741: > 739: } > 740: > 741: // On Vista: setting the window non-opaque makes the window look I would remove the On Vista: comment entirely or replace it with a "Since Vista," src/java.desktop/windows/native/libawt/windows/awt.h line 158: > 156: > 157: #define IS_WIN8 ( > \ > 158: (LOBYTE(LOWORD(::GetVersion())) == 6 && > (HIBYTE(LOWORD(::GetVersion())) >= 2)) || \ I'd be surprised if anyone runs the JVM on OSes pre-Windows-8, so that one can probably vanish, too. Windows 7 went EOL in 2020. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31762#pullrequestreview-4623802995 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3518223694 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3518226682 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3518240650
