On Fri, 10 Jul 2026 10:28:27 GMT, Alexey Ivanov <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unneeded comment > > src/java.desktop/windows/classes/sun/awt/Win32GraphicsEnvironment.java line 1: > >> 1: /* > > Bump the copyright year? You did it in previous PRs. Done! > src/java.desktop/windows/native/libawt/java2d/windows/WindowsFlags.cpp line 1: > >> 1: /* > > Bump the copyright year? Done! > src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp line > 93: > >> 91: >> 92: /** >> 93: * Returns true if dwm composition is enabled, false if dwm composition >> is disabled. > > Suggestion: > > * Returns true if DWM composition is enabled, false if DWM composition is > disabled. > > You're updating the comment, I'd use capital letters for DWM (Desktop Window > Manager). Changed it to DWM. > src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp line > 99: > >> 97: return (BOOL)dwmIsCompositionEnabled; >> 98: } >> 99: BOOL bRes = FALSE; > > I'd leave the blank line above `BOOL bRes = FALSE` — it separates the quick > return path from getting the state. > > FWIW, I may remove the blank line between this line and the next `try` block, > as they're closely related. I brought back the blank line. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3559949075 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3559951044 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3559943316 PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3559938869
