On Fri, 10 Jul 2026 17:26:03 GMT, Phil Race <[email protected]> wrote:

>> sun.java2d.noddraw property was used to render without d3d pipeline. However 
>> subsequent creation and use of sun.java2d.d3d property rendered it useless 
>> and obsolete.
>> We should consider removing it and replacing with sun.java2d.d3d property. 
>> We already have a start with JDK-8373493
>> 
>> CI testing is ok
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.desktop/windows/classes/sun/java2d/windows/WindowsFlags.java line 
> 172:
> 
>> 170:                 "javax.accessibility.screen_magnifier_present", false);
>> 171:         boolean ddEnabled =
>> 172:                 getBooleanProp("sun.java2d.d3d", magPresent);
> 
> It is one thing to update the tests to use the d3d property, but another 
> thing to remove the recognition of noddraw. This would be a compatibility 
> issue for apps that set it.
> This would need a CSR too. Also ddEnabled becomes obsolete.
> 
> You should consider backing off from making these source changes and just 
> update the tests.

In the source can we do this 

boolean noddraw = Boolean.getBoolean("sun.java2d.noddraw");
        System.setProperty("sun.java2d.d3d", Boolean.toString(!noddraw))

so that from user perspective noddraw is not withdrawn but internally we treat 
it as setting d3d property in reverse
and I guess in that case, CSR also will not be needed as we are not removing 
the property par se but just treating it as an extension/setting of another 
property

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31750#discussion_r3565859430

Reply via email to