On Mon, 13 Jul 2026 11:07:28 GMT, Matthias Baesken <[email protected]> wrote:
> We can remove the isXP() function from jabswitch.cpp because it deals with > very ancient Windows versions we do not support any more. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 67: > 65: GetVersionEx( &osvi ); > 66: > 67: if ( osvi.dwMajorVersion == 5 ) // For Windows XP and Windows 2000 This is looking for *exactly* version 5. In most cases we would want to know 5 or later .. So I'm not sure what the actual intent was here. Was It written back in NT days and wanted to behave differently on XP (and later) and been incorrect all this time ? Or perhaps just obsolete ? I'm not sure what was actually reading the registry entries. So I'm not sure I want to approve this fix as it stands. It needs more research and understanding. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31881#discussion_r3589443789
