On Fri, 17 Jul 2026 20:30:29 GMT, Phil Race <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Move paintString block to paint
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaProgressBarUI.java line 205:
> 
>> 203:             }
>> 204:             painter.paint(g2, progressBar, i.left, i.top, width, 
>> height);
>> 205:             if (progressBar.isStringPainted() && 
>> !progressBar.isIndeterminate()) {
> 
> You are now drawing this in a potentially flipped context, so you'll get 
> mirrored text.
> i.e the previous code restored the transform before calling paintString().
> Also in the 1.1 case the text will now be very blocky since you are painting 
> into an unscaled graphics.
> It might be better to move this block back into paint()

Moved

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31749#discussion_r3610288909

Reply via email to