On Tue, 21 Jul 2026 10:36:11 GMT, Alexey Ivanov <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove m_listDefWindowProc > > src/java.desktop/windows/native/libawt/windows/ComCtl32Util.h line 47: > >> 45: } >> 46: >> 47: WNDPROC SubclassHWND(HWND hwnd, WNDPROC _WindowProc); > > Suggestion: > > void SubclassHWND(HWND hwnd, WNDPROC _WindowProc); > > I suggest changing the return type of `SubclassHWND`. I already raised [this > concern](https://github.com/openjdk/jdk/pull/31814#discussion_r3558368596), > but now that the scope of the change has expanded, I think it's right to > change the return type in this PR. > > No return value will flag all the assignments of `SubclassHWND`, and we'll > get a cleaner code. I agree. Since this always returns NULL, it is better to return void. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31814#discussion_r3624733156
