On Mon, 20 Jul 2026 07:57:24 GMT, Jyothilekshmi <[email protected]> wrote:
>> Please review this >> >> Platforms tested: >> Windows 11, macOS, Linux, Ubuntu >> >> Summary: >> Update PanelRepaint manual test to make the test frame non-resizable, >> keeping the UI layout fixed during verification. While testing the >> non-resizable frame change, observed that tab focus traversal did not scroll >> lower rows into view. Set a clear size for the custom ScrollPanel so when >> focus moves with the Tab key, the selected row can scroll into view properly. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jyothilekshmi has updated the pull request incrementally with one additional > commit since the last revision: > > 8364404: PanelRepaint.java should not be resizable Other than the comment about the frame size calculations, the fix looks good to me. If the current hard-coded size doesn't lead to any issues where the user can possibly see the contents of the scrollable panel below the horizontal scroll bar, I'm fine with the current fix. test/jdk/java/awt/Panel/PanelRepaint/PanelRepaint.java line 73: > 71: Frame f = new Frame("Panel Repaint Test"); > 72: f.setLayout(new FlowLayout()); > 73: f.setSize(620, 288); This `setSize` relies on size of frame insets which include the system window decorations. To ensure the frame fits the `PanelRepaint pr` fully, you should calculate the size of the frame by combining the size of the panel and the insets of the frame. ------------- PR Review: https://git.openjdk.org/jdk/pull/31687#pullrequestreview-4755657415 PR Review Comment: https://git.openjdk.org/jdk/pull/31687#discussion_r3631251316
