On Thu, 23 Jul 2026 21:24:32 GMT, Phil Race <[email protected]> wrote:
>> test/jdk/javax/swing/JInternalFrame/8069348/bug8069348.java line 126:
>>
>>> 124: String d3d = System.getProperty("sun.java2d.d3d");
>>> 125: System.out.println("d3d " + d3d);
>>> 126: return !Boolean.parseBoolean(d3d) || getOSType() ==
>>> OSType.WINDOWS;
>>
>> The method looked weird, partly because of the name "isSupported() and I
>> wondered it is trying to achieve
>>
>> The only thing it does is prevent this invocation from running on mac & linux
>>
>> @run main/othervm -Dsun.java2d.d3d=true -Dsun.java2d.uiScale=2 bug8069348
>>
>> presumably because it duplicates this invocation :
>>
>> @run main/othervm -Dsun.java2d.uiScale=2 bug8069348
>>
>> But it wasn't stopping the same duplication on macOS .. in the ORIGINAL
>> version of the test
>>
>> 44 * @run main/othervm -Dsun.java2d.opengl=true -Dsun.java2d.uiScale=2
>> bug8069348
>>
>> was the default until metal came along
>>
>> It was removed by https://hg.openjdk.org/jdk/jdk/rev/3b820b878ebe
>>
>> So some of what isSupported() was trying to achieve is obsoleted.
>>
>> And anywatd3d is the default on windows where we can enable it and
>> specifying the property doesn't change anything.
>> i.e it does not force-enable it.
>>
>> I think to be useful it should have been
>>
>> @run main/othervm -Dsun.java2d.d3d=false -Dsun.java2d.uiScale=2 bug8069348
>>
>> then WHERE SUPPORTED this default line would be running the d3d case
>>
>> @run main/othervm -Dsun.java2d.uiScale=2 bug8069348
>>
>> So I suggest to just ditch the isSupported() method and use just the default
>>
>> @run main/othervm -Dsun.java2d.uiScale=2 bug8069348
>
> PS .. if you really still want to run it with different platforms and
> different options, then add
> multiple @test blocks with @requires tags
Removed isSupported and used the default pipeline
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32024#discussion_r3642752459
