On Thu, 30 Jul 2026 03:14:36 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> This regression test is added to verify the functional regression of paths >> getting closed between the edges when it should not. Visually this is seen >> as horizontal lines within the circle(Attachment in JBS shows this) that we >> are trying to draw. And mathematically the horizontal lines will be drawn at >> exact same place always for the given edges. So checking most of the center >> column pixels is more than sufficient to verify this regression. >> >> We are not trying to verify whether the whole circle is getting drawn >> properly. May be the summary was misleading, i have corrected the same. > > I made that perimeter check comment because the test checks for white pixel > and if nothing is drawn, then also the test will pass, so to mitigate that, I > think we should at least add this 2 checks > `if (area.isEmpty()) `and` if ((!area.contains(center, center))` so that we > know area is not empty and circle center is within the area > Also, bufferedimage can be dumped via ImageIO to see what kind of spurious > lines get drawn for future, in case it is needed. We are not checking for white pixels. We are clearing background with white color and drawing a black circle. After this we are checking for any non-white pixels within the circle. Checking for Area being empty when we initialize it with a valid shape or any other area verification is out of scope of what we are trying to do in this test. Its not like Area is volatile and it will be lost while we are processing it. This is not like other Area tests in this path where we are trying to modify the Area and checking whether it does those operations properly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31971#discussion_r3682998185
