On Wed, 29 Jul 2026 15:03:51 GMT, Matthias Baesken <[email protected]> wrote:
> Testing new MSVC warning flags > ([JDK-8388932](https://bugs.openjdk.org/browse/JDK-8388932)) revealed some > local initialized unused variables in jdk.accessibility. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). > > I think there is no need for the unused `bool freeData = false;` because we > > simply should always dynamically allocate the buffers in question (and of > > course always free them after usage). … > > So I would say just integrate this PR, but right afterwards fix the > > new/delete issues in jabswitch.cpp (I would be okay to prepare a follow up > > PR for this, because no one seems to work atm. on the existing issue > > [JDK-8348872](https://bugs.openjdk.org/browse/JDK-8348872) ). > > Comments ? Would be great to get the number of reviewers lowered to 2 again. > I plan to continue with the leaks afterwards in another PR this week. In my opinion, these unused `bool freeData = false;` should be removed _along_ with the fixes that prevent the leaks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32088#issuecomment-5194827651
