On Wed, 5 Aug 2026 21:50:52 GMT, Andy Goryachev <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Use state check
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3282:
> 
>> 3280:         for (int i = 0; i < columnModel.getColumnCount(); i++) {
>> 3281:             TableColumn column = columnModel.getColumn(i);
>> 3282:             if (column.getPreferredWidth() != 75 && column.getWidth() 
>> == 75) {
> 
> magic constant warning: testing for unrelated condition that might fail.  I 
> think you need to consider a different criteria.

it is needed because it is JTable/TableColumn’s default width and there's no 
constant for it as of now
It was already discussed in
https://github.com/openjdk/jdk/pull/29291#discussion_r2711110938

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31704#discussion_r3725689183

Reply via email to