On Fri, 7 Aug 2026 08:53:51 GMT, Matthias Baesken <[email protected]> wrote:
> There is a RegOpenKeyExA call present, but we do not close the handle. This > should be changed. > The MS docu says > https://learn.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regopenkeyexa > 'A pointer to a variable that receives a handle to the opened key. If the key > is not one of the predefined registry keys, call the > [RegCloseKey](https://learn.microsoft.com/en-us/windows/desktop/api/winreg/nf-winreg-regclosekey) > function after you have finished using the handle.' > And in this coding we call > `LONG lRet = ::RegOpenKeyExA(hRootKey, lpszSubKey, 0, KEY_ALL_ACCESS, &hKey); > ` > with a non_NULL `lpszSubKey `so the RegCloseKey has to be done. > > Also fixed a typo while at it. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: db3e0a5f Author: Matthias Baesken <[email protected]> URL: https://git.openjdk.org/jdk/commit/db3e0a5f600f1fd2eca2fb3cc96f0784652f332b Stats: 10 lines in 1 file changed: 7 ins; 0 del; 3 mod 8389901: [windows] CCombinedSegTable::GetEUDCFileName from awt_Font.cpp seems to miss RegCloseKey calls Reviewed-by: prr, azvegint ------------- PR: https://git.openjdk.org/jdk/pull/32249
