On Thu, 10 Sep 2026 12:35:21 GMT, Prasanta Sadhukhan <[email protected]> wrote:
> I am not sure if excluding edge pixels is the way to go...We have similar > test DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > where edge pixels are not excluded and still it passes for scale 1.25, 1.75, > 2.25 > > Maybe we can retain windows and de-PL for other platforms First check in OnScreenRenderingResizeTest sees whether we have white(background)/green(foreground) color after leaving top & left edge pixels by 10 pixels and half of image width & height. So basically it checks whether we are drawing something. Second check verifies that only white color is there where we don't draw any green(foreground) color after leaving edge pixels from all 4 sides. The color checks in current version of OverriddenInsetsTest are very strict compared to what we have in OnScreenRenderingResizeTest. This is not right comparison. After checking OnScreenRenderingResizeTest, i think just excluding 1 edge pixel may not be enough. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32779#issuecomment-5619200456
