On Fri, 18 Sep 2026 14:31:49 GMT, Alexey Ivanov <[email protected]> wrote:
>>> > I wonder whether isXPPlatform is needed at all, seemingly >>> > WindowsPlacesBar is a Windows-specific class. >> >> Yes WindowsPlacesBar is only used on Windows >> >> https://github.com/search?q=repo%3Aopenjdk%2Fjdk+WindowsPlacesBar&type=code >> >> Should we maybe move it to jdk/src/java.desktop/windows ? >> But I would prefer doing it in a follow up change. > > I don't think we can move the class to a different package now. Even though > apps shouldn't have used it, there are chances that there are apps or L&Fs > which did, and moving the class would break those apps. > > The comment above the class declaration suggests the class was accessed from > two different packages. > > https://github.com/openjdk/jdk/blob/a71f4dc2a77bb7837fb9ff2779f14afc7042153f/src/java.desktop/share/classes/sun/swing/WindowsPlacesBar.java#L58-L60 > > Yet I can't find any usages except for `WindowsFileChooserUI`. > > `WindowsPlacesBar` should've been in the `com.sun.java.swing.plaf.windows` > package along with `WindowsFileChooserUI`. It's fine to remove the `isXPPlatform` variable in a follow-up issue. If it is here to stay, I'm for renaming it because its value is no longer XP-related. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r4048815315
