On Thu, 17 Sep 2026 21:27:44 GMT, Phil Race <[email protected]> wrote:

> This test used to fail on macOS because the core text path was used for 
> layout and it always applied fractional metrics
> 
> On Linux the problem is that for visual bounds we use FT_Outline_Get_BBox() 
> which operates in fixed point, whereas when obtaining the bounds from a 
> GeneralPath (ie TextLayout.getOutline(), Java 2D uses double precision.
> Allowing 1/32 pixel rounding error seems like a reasonable course of action.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/java/awt/font/TextLayout/TextLayoutBounds.java line 30:

> 28: 
> 29: import java.awt.Font;
> 30: import java.awt.GraphicsEnvironment;

java.awt.GraphicsEnvironment is unused?

test/jdk/java/awt/font/TextLayout/TextLayoutBounds.java line 61:

> 59:             System.out.println("GV Outline Bounds="+gvoBounds);
> 60:             System.out.println("TL Bounds="+tlBounds);
> 61:             System.out.println("TL Outline bounds="+tlBounds);

"oBounds" should be used instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32931#discussion_r4078980108
PR Review Comment: https://git.openjdk.org/jdk/pull/32931#discussion_r4078975713

Reply via email to