On Tue, 29 Sep 2026 10:36:16 GMT, Alexander Zvegintsev <[email protected]> wrote:
>> Fixed three potential null pointer dereferences: >> * Two in log messages. >> * One during cleanup after a failed realloc, which also leaked the original >> allocation. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Zvegintsev has updated the pull request incrementally with four > additional commits since the last revision: > > - combine CHECK_VARIANT_TYPE with g_variant_get > - CHECK_VARIANT_TYPE check before g_variant_get calls > missing g_variant_unref added > - remove unused err from g_variant_get > - fix unref for g_variant_iter_loop src/java.desktop/unix/native/libawt_xawt/awt/screencast_portal.c line 235: > 233: if (!retVersion) { //no backend on system > 234: DEBUG_SCREENCAST("!!! could not detect the %s version\n", > interface); > 235: ERR_HANDLE(err); How it should work in non-debug build? The ERR_HANDLE will print error unconditionally? should it depends on DEBUG_SCREENCAST_ENABLED or something like that? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33059#discussion_r4152294176
