On Tue, 6 Oct 2026 22:45:56 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8393473 > > src/java.desktop/share/native/libmlib_image/mlib_ImageConvMxN_Fp.c line 83: > >> 81: /***************************************************************/ >> 82: mlib_status mlib_ImageConvMxN_Fp(mlib_image *dst, >> 83: const mlib_image *src, > > Looks like the next function still mentioned in > https://github.com/openjdk/jdk/blob/054dbd7b6a64c5fd6c3885e5bd1ade03bc80bc9a/src/java.desktop/share/native/libmlib_image/mlib_image_proto.h#L2657 > ? You know .. there's quite a few definitions in there that relate to functions that aren't anywhere to be found. At least 'grep' shows them only in that file. I'll update it to remove the FP convolution ones removed in this PR, and after this is integrated I'll take a look at how many of the rest are un-used. That file is 3400 lines long so I do not want to pollute this PR with all of that which might amount to a lot. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33184#discussion_r4222806478
