On Mon, 5 Oct 2026 19:10:38 GMT, Phil Race <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Windows Progrssbar fix
>
> test/jdk/java/awt/PrintJob/PrintProgressBarTest.java line 71:
> 
>> 69:     private static JFrame createTestUI() {
>> 70:         JPanel panel = new JPanel(new FlowLayout());
>> 71:         JProgressBar ltrBar = new JProgressBar();
> 
> iI won't insist, but would have been nice to test VERTICAL too.
> I tried it and it does work although the test doesn't layout well in that 
> case, and also Swing doesn't seem to know what to do with RTL in that case.

I've reflected on this and I keep having to edit the test to verify the 
vertical printing, so I think the test should include cases of
new JProgressBar(javax.swing.SwingConstants.VERTICAL);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31749#discussion_r4416777844

Reply via email to