On Fri, 30 Oct 2026 11:46:14 GMT, Matthias Baesken <[email protected]> wrote:

> In X11GD_CreateDisplayMode we check for NULL after GetMethodID and FindClass 
> which is probably a good thing.
> https://github.com/openjdk/jdk/blob/8e8e30d71cc8f77d81170205a4627191e5201568/src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c#L1638
> 
> https://github.com/openjdk/jdk/blob/8e8e30d71cc8f77d81170205a4627191e5201568/src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c#L1646
> 
> But we do it twice (!) which is most likely not needed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This pull request has now been integrated.

Changeset: d5c3d275
Author:    Matthias Baesken <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/d5c3d275fc4994d8b7464df9febd624d35e0ba52
Stats:     8 lines in 1 file changed: 0 ins; 5 del; 3 mod

8394750: Double NULL checks in X11GD_CreateDisplayMode (awt_GraphicsEnv.c)

Reviewed-by: prr, clanger

-------------

PR: https://git.openjdk.org/jdk/pull/33647

Reply via email to