On Sunday, December 14, 2014 6:56:28 AM UTC-5, Boris Kourtoukov wrote: > On Sunday, December 14, 2014 6:53:53 AM UTC-5, Thomas Heller wrote: > > I noticed this a while back [1]. I ended up not caring anymore since it > > doesn't hurt and is removed by :advanced anyways. > > > > FWIW it is caused by the alias (:require [clojure.string :as str]) which > > ends with goog.require for 'clojure.string and 'str (which resolves to > > 'clojure.string). Without an alias you don't get 2 requires. I had a patch > > for this but it is very out of date and never made it to JIRA cause at the > > time I was working off my own CLJS fork. > > > > We should go through the proper channels this time. ;) > > > > [1] > > https://groups.google.com/forum/#!topic/clojurescript/rq65Kuh9Q4Q/discussion > > > > On Sunday, December 14, 2014 12:25:46 PM UTC+1, Boris Kourtoukov wrote: > > > I am noting the following in the compiled JS output when using > > > optimizations :none > > > > > > goog.provide('simple_test.core'); > > > goog.require('cljs.core'); > > > goog.require('simple_test.beta'); > > > goog.require('clojure.string'); > > > goog.require('clojure.string'); > > > goog.require('simple_test.beta'); > > > goog.require('simple_test.alpha'); > > > goog.require('simple_test.alpha'); > > > > > > Here is a gist with the bare source: > > > https://gist.github.com/BorisKourt/df7bea77b4b5bffa06a4 (Its just the > > > mies template with two additional .cljs files) > > > > > > Is this normal behavior? I don't recall seeing this duplication a few > > > months ago. I will file a bug report if this is indeed odd. > > Should it duplicate on a :refer without an :as ? I have that happening for > simple-test/beta in the example. > > Good idea about official channels, if you still have the patch how should we > go about this? :)
Looks like it does it only on :require and :as, tested with just [simple-test.alpha] and no duplication. I agree that it is not hurting a whole lot as latter optimization levels clean this out. I do wonder if it is causing any performance hit for the Google Closure compiler with something like :advanced? Unlikely but still. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/clojurescript.
