Hi Thomas, thanks for the feedback! The goog.* libraries are still a bit of a black box to me, but you're right, I should look into them more since they don't introduce an external dependency and are built right into the Closure compiler.
On a more philosophical level, I'm not totally crazy about tying the ClojureScript ecosystem so directly to the Closure libraries, as opposed to the compiler, since (at least in theory) a different JS compiler could be released which didn't have those libraries as a dependency. I generally take a pragmatic viewpoint towards these things, though, and obviously a lot of time went into making and testing the Closure libraries and they should be used if they can. I just sometimes wish they seemed a little less like an internal Google tool that somebody accidentally pushed to github one day. Anyways, I went with Pikaday out of lassitude as much as anything else, since it already has a cljsjs entry, and following that same train of thought it's even less effort to use the Google stuff, so I'll definitely look into it. I've also been thinking about using cljs-time in the public interface, and that uses goog.date.* libraries, so that's another nudge in the Closure direction. Also, thanks for publishing those demos, they are quite helpful. Tim On Sunday, April 5, 2015 at 6:05:00 AM UTC-4, Thomas Heller wrote: > Hey Tim, > > I have no real feedback for you since I don't use Reagent or Om but thought I > should mention that it might be better to leverage what the Closure Library > has to offer before grabbing external Javascript. > > The Closure Library comes with a full fledged DatePicker that is fully > internationalized. Couldn't find the official demos so I uploaded them on my > server [1]. See [2],[3],[4] for DatePicker demos. > > The advantage of using Closure compliant Javascript is that it fully supports > the :advanced compilation mode and will properly eliminate unused code, thus > resulting in smaller files. The code generally is also well tested and > documented since it is used in many Google Products. > > There is a lot more stuff in Closure that doesn't have demos so I'd recommend > browsing the code [5] and maybe grep for what you are looking for. I pretty > much found everything I ever needed in there. > > IMHO non-Closure JS should pretty much be the last resort not the first > choice. > > HTH, > /thomas > > [1] http://www.zilence.net/closure-library/closure/goog/demos/ > [2] http://www.zilence.net/closure-library/closure/goog/demos/datepicker.html > [3] > http://www.zilence.net/closure-library/closure/goog/demos/inputdatepicker.html > [4] > http://www.zilence.net/closure-library/closure/goog/demos/popupdatepicker.html > [5] https://github.com/google/closure-library > > > On Saturday, April 4, 2015 at 12:14:57 AM UTC+2, Tim Gilbert wrote: > > Hi all... I have just released cljs-pikaday, which is a ClojureScript > > interface to the Pikaday javascript date-picker. > > > > https://github.com/timgilbert/cljs-pikaday/ > > > > It's a pretty simple little library in its early stages. Right now there's > > just a reagent interface where you can pass an atom into a component which > > will be updated when the user selects a date. > > > > There's a simple demo page here: > > > > http://timgilbert.github.io/cljs-pikaday/reagent-example/ > > > > I'm planning to add an Om interface to it, as well as a nicer interface for > > re-frame. > > > > This is my first published ClojureScript library, so any feedback on the > > design or implementation would be welcome. (I've also since realized that > > there are approximately 3 million javascript date-pickers out there with > > various features, so the name might be unfortunate if I switch to another > > implementation, but oh well.) > > > > Tim -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/clojurescript.
