My only real comment is that I thikn i'd take 'get_metadata' out of 'get_data'. You can either move it to a stand alone method or a class method. either way, moving it out allows to easier patch it for testing.
-- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
