On Wed, Oct 19, 2016 at 8:52 AM, Ryan Harper <ryan.har...@canonical.com> wrote:
> > > On Wed, Oct 19, 2016 at 8:04 AM, Scott Moser <smo...@ubuntu.com> wrote: > >> over all, looks good. >> you dont have to clean up the handle, but if you see easy way to do that >> that'd be nice. >> >> is the snappy path now valid on non-snappy system ? (ubuntu server with >> 'snap' support). >> > > It is, and util.is_system_snappy() I think passes where it works; I'll > confirm. > is_system_snappy is looking for 'all-snap' style images; so snaps on classic don't respond. We'd need to design something for validating that it works on snaps on classic setups. One key difference is that all-snap systems have non-writable /etc ; where as snapd on classic doesn't. If we added classic systems to the is_system_snappy check, then users would get added to /var/lib/extrausers instead of /etc; I think that's non-optimal and introduces changes to existing behavior. Ryan -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/304700 Your team cloud init development team is requested to review the proposed merge of ~raharper/cloud-init:snapuser-create into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
