Josh, this looks great. Thank you. The only thing I don't like now is the duplication.
There are 2 ways i can think of to reduce it: a.) both tests extend a base class that has the test_* functions. this is just less flexible than 'b', but because these things are identical now, its the easiest thing. I started to write in text how you could do this, but found that it was just as easy to do it myself and describe it that way. I think acceptable: http://paste.ubuntu.com/24195190/ The thing i'm not sure of is if we need to somehow make sure that the 'PasswordListTest' base class somehow doesnt run. In curtin vmtest we always did this with __test__ = False. I'm happy that it doesnt appear we need this, but I didn't yet run a full simple 'run' without specific -t b.) some helper functions for testing this, and then the test_* functions will have call helper functions and have less in them. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319878 Your team cloud init development team is requested to review the proposed merge of ~powersj/cloud-init:test-set-password-list into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
