Review: Approve
I think we agreed in standup that since you've fixed this with a workaround for
pylint's bug, you could probably add a structured comment or something that
mark that we should look at pylint tip in the future to see if that issue is
fixed. For bugs on external dependencies which cloud-init expects to be fixed
at some in the future, we probably should decide on a comment label or
something if we need to revisit this logic in the future to clean it up or
remove a workaround. (like # RELEASE_REVIEW or RELEASE_BLOCKER). Then we can
have a simple grep to search for fixes or old external bugs we should double
check upon next SRU.
Diff comments:
> diff --git a/setup.py b/setup.py
> index 4616599..a61c24a 100755
> --- a/setup.py
> +++ b/setup.py
> @@ -76,6 +77,9 @@ INITSYS_ROOTS = {
> 'systemd': pkg_config_read('systemd', 'systemdsystemunitdir'),
> 'systemd.generators': pkg_config_read('systemd',
> 'systemdsystemgeneratordir'),
> + 'systemd.fsck-dropin': (
> + os.path.sep.join([pkg_config_read('systemd', 'systemdsystemunitdir'),
Chatted in IRC, os.path.sep.join is more defensive in the event that the 2nd
arg is already prefixed by a leading /.
> + '[email protected]'])),
> 'upstart': '/etc/init/',
> }
> INITSYS_TYPES = sorted([f.partition(".")[0] for f in INITSYS_ROOTS.keys()])
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324401
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master.
_______________________________________________
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
