On Wed, Oct 4, 2017 at 9:28 AM, Andrew Jorgensen <[email protected]> wrote:
> > In an exception path, I don't think this matters; > > Do I take this to mean it's okay as it is now, and you approve? Or would > you like me to undo the change that Scott suggested before it gets merged? > That was a comment for Scott; I'm find with his suggested change; I just wanted to comment on the general case w.r.t str() vs. %s formatting overhead. > -- > https://code.launchpad.net/~ajorgens/cloud-init/+git/ > cloud-init/+merge/331660 > Your team cloud-init commiters is requested to review the proposed merge > of ~ajorgens/cloud-init:_include-urlerror into cloud-init:master. > > _______________________________________________ > Mailing list: https://launchpad.net/~cloud-init-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~cloud-init-dev > More help : https://help.launchpad.net/ListHelp > -- https://code.launchpad.net/~ajorgens/cloud-init/+git/cloud-init/+merge/331660 Your team cloud-init commiters is requested to review the proposed merge of ~ajorgens/cloud-init:_include-urlerror into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
