@raharper and @chad.smith Thanks for review and comments.
Fixed: Test location and IPv4 regular expression. Comments and questions on the other info you provided. As far as the test data is concerned, I kind of did a cut and paste from existing tests based on network configuration for the distros. I really have no idea what the various data sources can and cannot produce and what the debian/ubuntu format looks like. So test data that conforms to what the data sources produce would be better. If there is concrete data, that I should be using and have not used, please point me in that direction. Same can be applied to the suggested change of the search for "default gw", I agree that the proposed expression is more flexible, but does it need to be, i.e. do we have a data source where there is a varying space? Yes there is always the risk that a new data source may format things differently, but the question would then be if we should compensate for such potential future discretions now or not. -- https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333904 Your team cloud-init commiters is requested to review the proposed merge of ~rjschwei/cloud-init:netV1ToTranslate into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
