Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index e73b57b..a56ced2 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -591,6 +591,18 @@ def address_ephemeral_resize(devpath=RESOURCE_DISK_PATH, > maxwait=120, > return > > > +def _is_bounce_command_missing_dependency(command): > + '''Return True if bounce command is unsupported.''' > + if isinstance(command, (list, tuple)): it seems an arbitrary false positive on _is_bounce_command_missing_dependency(["sh", "-c", "echo here you could call ifdown, but we will not."]) possibly contrived, but really i think i'm ok to just ditch this functionality. only ever calling the bounce command if there is an ifup and an ifdown. that seems arbitrary as well, but i suspect that there are no users that specify their own that do not use a username of 'smoser'. > + for item in command: > + if 'ifdown' in item and not util.which('ifdown'): > + return True > + else: > + if 'ifdown' in command and not util.which('ifdown'): > + return True > + return False > + > + > def perform_hostname_bounce(hostname, cfg, prev_hostname): > # set the hostname to 'hostname' if it is not already set to that. > # then, if policy is not off, bounce the interface using command -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335470 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp