hi scott,

from a theoretical point of view i totally agree with you. the reason why i 
added those 3 cfg variables to the distro module was that it is currently not 
maintained like this everywhere. for example the variable cfg['ssh_svcname'] is 
also configured in the distro classes instead of the corresponding cc_ssh*.py 
classes. one may say ssh is such a basic service which is used in many 
different places in the code so it makes sense to have it in the distro...?

never the less i think in the case of cc_salt_minion it really makes sense to 
have these params not defined in the distro. i have created an implementation 
idea that follows the mentioned standard but to be honest the new version 
doesn't look as neat to me as the previous version. what are your thoughts? 
check out the patch here: 
https://git.launchpad.net/~d-info-e/cloud-init/commit/?id=c7c9f90714dcd127faf861e63e465a65d79277fa

i haven't tested it yet but if you think that is nice and good i will merge it 
to this branch here.

cheers
dom
-- 
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/340112
Your team cloud-init commiters is requested to review the proposed merge of 
~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master.

_______________________________________________
Mailing list: https://launchpad.net/~cloud-init-dev
Post to     : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to