The proposal to merge ~smoser/cloud-init:cleanup/ds-identify-shellcheck-fixes into cloud-init:master has been updated.
Commit message changed to: ds-identify: make shellcheck 0.4.6 happy with ds-identify. This fixes warnings reported by shellcheck at 0.4.6. The complaints that we are ignoring globally (top of the file) are: 2015: Note that A && B || C is not if-then-else. C may run if A is true. 2039: In POSIX sh, 'local' is undefined. 2162: read without -r will mangle backslashes. 2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. Most of the complaints were just noise, but a few unused variables were reported and fixed. Related shellcheck issues opened: - https://github.com/koalaman/shellcheck/issues/1191 - https://github.com/koalaman/shellcheck/issues/1192 - https://github.com/koalaman/shellcheck/issues/1193 - https://github.com/koalaman/shellcheck/issues/1194 For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/344768 -- Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/ds-identify-shellcheck-fixes into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
