The proposal to merge ~smoser/cloud-init:fix/fix-dhclient-hook-down into cloud-init:master has been updated.
Commit message changed to: dhclient-hook: cleanups, tests and fix a bug on 'down' event. I noticed a bug in dhclient_hook on the 'down' event, using 'is' operator rather than '==' (if self.net_action is 'down'). This refactors/simplifies the code a bit for easier testing and adds tests. The reason for the rename of 'action' to 'event' is to just be internally consistent. The word and Namespace 'action' is used by cloud-init main, so it was not really usable here. Also adds a main which can easily be debugged with: CI_DHCP_HOOK_DATA_D=./my.d python -m cloudinit.dhclient_hook up eth0 For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/356428 -- Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/fix-dhclient-hook-down into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp