On Wed, Sep 04, 2019 at 06:30:07PM -0000, Ryan Harper wrote: > If the interface already has an IP, it may not have anything else that > we'd apply after parsing the lease output (routes, etc).
If the interface already has an IP before we DHCP, it's not 100% clear to me that we should consider routes etc. from the DHCP response applicable. > This sort of feels OK in that we skip tearing down when we don't do > anything else, but it also seems wrong in that the whole context > manager should exit if we don't bring up DHCP. What do you mean by "should exit" here? The way we use the context manager (in DataSourceOpenStack, at least), is essentially "ensure I have network while executing the body", so not needing to configure networking isn't really an error condition in that usecase. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372289 Your team cloud-init commiters is requested to review the proposed merge of ~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
