On 23/04/17, Dusty Mabe wrote: > > > On 04/22/2017 10:31 AM, Dharmit Shah wrote: > > Hi, > > Hey Dharmit, > > Thanks for working on this! > > > > > After setting up gofed on my system, I did: > > > > $ gofed repo2spec --detect https://github.com/digitalocean/doctl > > --commit bb6a9630426adc1fed74f93df6f749deae6530aa > > > > since that's the commit ID for latest version - 1.6.0. > > > > After that I did: > > > > $ gofed fetch --spec > > > > to download the tarball. > > > > Doing a local build or mockbuild is failing. In case of local build, > > it's throwing [1] while for mockbuild I'm seeing this [2]. > > So there are two ways to build go packages in Fedora. One is to build > from the source of a bunch of devel packages that have already been > packaged up for Fedora. The other is to "bundle" all of that stuff and > essentially provide the source for all of those deps within this > package itself. > > I believe it is preferable to build from the source of all the devel > packages that are already a part of Fedora, but that is the long/hard > approach because we have to package up the source files into devel > rpms for all of them. It's not really hard to do this, and would be > great if you did, but not required. An example of bundling the source > code is here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1418368 > > If you want to bundle instead, an example is the kompose rpm here: > > https://src.fedoraproject.org/cgit/rpms/kompose.git/tree/ >
Also have a look at the gotun review [1], where I also started with the gofed generated spec, and then changed for the dependencies as Jan helped to do package the deps. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1386625 Kushal > You can do a diff between kompose.spec and kompose.spec.orig to see > what changes were made. Also, check out the notes.txt file. > > > > > For both cases, it seems to me like missing Go dependencies are the > > issue. How am I supposed to make these dependencies available? > > > > Also, just want to know if I'm following the right steps. The specfile > > generated by repo2spec command is intimidating! > > It can be :). We'll help you through it! > > > > > [1] > > https://paste.fedoraproject.org/paste/P-t~p-RmBzpVb8nl0avICF5M1UNdIGYhyRLivL9gydE= > > [2] > > https://paste.fedoraproject.org/paste/WkcqyLNWkfuysR0OUpsrdl5M1UNdIGYhyRLivL9gydE= > > > > Regards, > > Dharmit. > _______________________________________________ > cloud mailing list -- [email protected] > To unsubscribe send an email to [email protected] -- Fedora Cloud Engineer CPython Core Developer https://kushaldas.in https://dgplug.org _______________________________________________ cloud mailing list -- [email protected] To unsubscribe send an email to [email protected]
