Updated Branches: refs/heads/master 6c30700fa -> 860d1bc73
api: createStoragePool requires podId, clusterId The CreateStoragePool API requires that podId, clusterId be passed or it fails. Bug found in cli, which in turn got it from Marvin, which got it from commands.xml which got from ApiXmlDocWriter. Patch adds required field on podId, so it trickle downs to cli. Signed-off-by: Rohit Yadav <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/860d1bc7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/860d1bc7 Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/860d1bc7 Branch: refs/heads/master Commit: 860d1bc73dd891e566e76dad6c1eb178b29bf648 Parents: 6c30700 Author: Rohit Yadav <[email protected]> Authored: Wed Nov 7 13:43:16 2012 +0530 Committer: Rohit Yadav <[email protected]> Committed: Wed Nov 7 14:05:31 2012 +0530 ---------------------------------------------------------------------- .../cloud/api/commands/CreateStoragePoolCmd.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/860d1bc7/api/src/com/cloud/api/commands/CreateStoragePoolCmd.java ---------------------------------------------------------------------- diff --git a/api/src/com/cloud/api/commands/CreateStoragePoolCmd.java b/api/src/com/cloud/api/commands/CreateStoragePoolCmd.java index 69c1bb5..8926ea7 100644 --- a/api/src/com/cloud/api/commands/CreateStoragePoolCmd.java +++ b/api/src/com/cloud/api/commands/CreateStoragePoolCmd.java @@ -45,7 +45,7 @@ public class CreateStoragePoolCmd extends BaseCmd { ///////////////////////////////////////////////////// @IdentityMapper(entityTableName="cluster") - @Parameter(name=ApiConstants.CLUSTER_ID, type=CommandType.LONG, description="the cluster ID for the storage pool") + @Parameter(name=ApiConstants.CLUSTER_ID, type=CommandType.LONG, required=true, description="the cluster ID for the storage pool") private Long clusterId; @Parameter(name=ApiConstants.DETAILS, type=CommandType.MAP, description="the details for the storage pool") @@ -55,7 +55,7 @@ public class CreateStoragePoolCmd extends BaseCmd { private String storagePoolName; @IdentityMapper(entityTableName="host_pod_ref") - @Parameter(name=ApiConstants.POD_ID, type=CommandType.LONG, description="the Pod ID for the storage pool") + @Parameter(name=ApiConstants.POD_ID, type=CommandType.LONG, required=true, description="the Pod ID for the storage pool") private Long podId; @Parameter(name=ApiConstants.TAGS, type=CommandType.STRING, description="the tags for the storage pool")
