Updated Branches: refs/heads/add_remove_nics 072521c35 -> 4d369994d
Summary: Remove some todo lines that have been addressed Signed-off-by: Marcus Sorensen <[email protected]> 1359158121 -0700 Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/4d369994 Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/4d369994 Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/4d369994 Branch: refs/heads/add_remove_nics Commit: 4d369994d4e8474a2bc58ecb98420bd6e9480445 Parents: 072521c Author: Marcus Sorensen <[email protected]> Authored: Fri Jan 25 16:55:21 2013 -0700 Committer: Marcus Sorensen <[email protected]> Committed: Fri Jan 25 16:55:21 2013 -0700 ---------------------------------------------------------------------- server/src/com/cloud/vm/UserVmManagerImpl.java | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/4d369994/server/src/com/cloud/vm/UserVmManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java b/server/src/com/cloud/vm/UserVmManagerImpl.java index 1fb033f..2ab88e2 100644 --- a/server/src/com/cloud/vm/UserVmManagerImpl.java +++ b/server/src/com/cloud/vm/UserVmManagerImpl.java @@ -953,7 +953,6 @@ public class UserVmManagerImpl implements UserVmManager, UserVmService, Manager } } - //todo: any security group related checks //ensure network belongs in zone if (network.getDataCenterId() != vmInstance.getDataCenterIdToDeployIn()) { throw new CloudRuntimeException(vmInstance + " is in zone:" + vmInstance.getDataCenterIdToDeployIn() + " but " + network + " is in zone:" + network.getDataCenterId()); @@ -963,7 +962,6 @@ public class UserVmManagerImpl implements UserVmManager, UserVmService, Manager s_logger.debug(vmInstance + " already in " + network + " going to add another NIC"); } - //todo: check other nics for VPC networks (can only belong to one?) //todo: verify unique hostname in network domain? NicProfile guestNic = null;
