Updated Branches:
refs/heads/master bd825109d -> 77e3aade0
CS-CLOUDSTACK-606:
The issue happens randomly when hosts in a cluster gets distributed across
multiple MS. Host can get split in following scenarios:
a. Add host â MS on which add host is executed takes ownership of the
host. So if 2 hosts belonging to same cluster are added from 2 different MS
then cluster gets split
b. scanDirectAgentToLoad â This runs every 90 secs. and check if there
are any hosts that needs to be reconnected. The current logic of host scan can
also lead to a split
The idea is to fix (b) to ensure that hosts in a cluster are managed by
same MS. For (a) only the entry in the database is going to be created except
in case if the host getting added is first in the cluster (in this case agent
creation happens at the same time) and then (b) will take care of connection
and agent creation part. Since currently addHost only creates an entry in the
db there is a small window where the host state will be shown as 'Alert' till
the time (b) is scheduled and picks up the host to make a connection. The MS
doing add host will immediately schedule a scan task and also send notification
to peers to start the scan task.
Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit:
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/77e3aade
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/77e3aade
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/77e3aade
Branch: refs/heads/master
Commit: 77e3aade03b756762d73c0739653d71a85ad8c2d
Parents: bd82510
Author: Koushik Das <[email protected]>
Authored: Fri Feb 1 16:58:29 2013 +0530
Committer: Nitin Mehta <[email protected]>
Committed: Fri Feb 1 16:58:29 2013 +0530
----------------------------------------------------------------------
.../agent/api/ScheduleHostScanTaskCommand.java | 32 +++++++++++++++
1 files changed, 32 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/77e3aade/api/src/com/cloud/agent/api/ScheduleHostScanTaskCommand.java
----------------------------------------------------------------------
diff --git a/api/src/com/cloud/agent/api/ScheduleHostScanTaskCommand.java
b/api/src/com/cloud/agent/api/ScheduleHostScanTaskCommand.java
new file mode 100755
index 0000000..e938de7
--- /dev/null
+++ b/api/src/com/cloud/agent/api/ScheduleHostScanTaskCommand.java
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/*
+ * This is used to schedule an explicit host scan in MS peers. Currently used
during
+ * add host operation so that correct MS can take host ownership. On receiving
the
+ * command the scan is scheduled immediately.
+ */
+public class ScheduleHostScanTaskCommand extends Command {
+ public ScheduleHostScanTaskCommand() {
+ }
+
+ @Override
+ public boolean executeInSequence() {
+ return false; // standalone command and can be executed independent of
other commands
+ }
+}