Hello David/Edison, Apologies for placing such a huge pull request.
I was trying to rebase my fork against the new changes in CloudStack repo. As my fork was not updated from a long time which resulted in merge conflicts and confusion. But, now after deleting old repo and re-forking the CS repo I was able to rebase successfully. I have closed the pull request. Thanks again for your help. Regards, Mayur On Tue, May 22, 2012 at 1:15 AM, Edison Su <edison...@citrix.com> wrote: > > -----Original Message----- > > From: David Nalley [mailto:da...@gnsa.us] > > Sent: Monday, May 21, 2012 11:54 AM > > To: cloudstack-dev@incubator.apache.org > > Subject: Fwd: [CloudStack] Fetching new changes (#13) > > > > Forwarding this along - and adding my comments here. > > > > Mayur - this is a gigantic, 600k line pull request. I am hoping you > > were actually trying to rebase your repo, but perhaps I am wrong. > > > > If this is really a pull request, let me say things for the work - BUT > > - it's so massive as to be effectively unreviewable, you seem to be > > touching virtually every module in CloudStack, and there are scores of > > bugs referenced. > > > > Each bug (or at most 2-3 if they are closely related) should be it's > > own patch/pull request. Second - you should really think twice about > > submitting a pull request/patch that touches more than a single > > module. > > I am confused also, take a look at the pull request, seems all the patches > are coming from cloudstack.
